apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: [Patch] RE: Windows drive letter check fails on lower case current working drive
Date Wed, 20 Jan 2010 06:02:51 GMT
On 1/19/2010 5:19 AM, Bert Huijben wrote:
> 
> The patch was written on the 1.4.x branch but I svn switch'ed it to trunk for easy application.

I would suggest one bit of alternate code that is a bit more condensed, any
concern?;

+static int same_drive(const char *path1, const char *path2)
+{
+    if ((path1[0] < 'A' || (path1[0] > 'Z' && path1[0] < 'a') || path1[0]
> 'Z')
+     || (path2[0] < 'A' || (path2[0] > 'Z' && path2[0] < 'a') || path2[0]
> 'Z')
+     || path1[1] != ':' || path2[1] != ':')
+        return 0;

+    /* Once in the domain of ASCII alpha, compare these case insensitive */
+    return ((path1[0] & 0x1f) == (path2[0] & 0x1f));
+}

Mime
View raw message