Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 22803 invoked from network); 19 Dec 2009 13:22:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 19 Dec 2009 13:22:36 -0000 Received: (qmail 78959 invoked by uid 500); 19 Dec 2009 13:22:35 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 78844 invoked by uid 500); 19 Dec 2009 13:22:34 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 78836 invoked by uid 99); 19 Dec 2009 13:22:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Dec 2009 13:22:34 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [194.242.35.75] (HELO dns-factory.at) (194.242.35.75) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Dec 2009 13:22:27 +0000 Received: from [172.17.100.14] apache@gknw.net [84.63.65.76] by dns-factory.at with NetMail SMTP Agent $Revision: 8582 $ on Novell NetWare via secured & encrypted transport (TLS); Sat, 19 Dec 2009 14:21:53 +0100 Message-ID: <4B2CD36F.3040007@apache.org> Date: Sat, 19 Dec 2009 14:21:51 +0100 From: Guenter Knauf User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: dev@apr.apache.org Subject: Re: svn commit: r892141 - in /apr/apr/trunk/include: apr.hnw arch/netware/apr_private.h References: <20091218052043.5D85823889DE@eris.apache.org> In-Reply-To: <20091218052043.5D85823889DE@eris.apache.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Bill, wrowe@apache.org schrieb: > Author: wrowe > Date: Fri Dec 18 05:20:42 2009 > New Revision: 892141 >=20 > URL: http://svn.apache.org/viewvc?rev=3D892141&view=3Drev > Log: > Netware changes; always include netware.h/library.h for > whatever local functions or types would be aliased, in > a public manner, and drop very stale references to flavors > which should not be in common use. >=20 > It's not necessary to exclude by platform, is it? >=20 > Modified: > apr/apr/trunk/include/apr.hnw > apr/apr/trunk/include/arch/netware/apr_private.h >=20 > Modified: apr/apr/trunk/include/arch/netware/apr_private.h > URL: http://svn.apache.org/viewvc/apr/apr/trunk/include/arch/netware/ap= r_private.h?rev=3D892141&r1=3D892140&r2=3D892141&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- apr/apr/trunk/include/arch/netware/apr_private.h (original) > +++ apr/apr/trunk/include/arch/netware/apr_private.h Fri Dec 18 05:20:4= 2 2009 > @@ -16,28 +16,13 @@ > =20 > /* > * Note:=20 > - * This is the windows specific autoconf-like config file > - * which unix would create at build time. > + * This is the netware-specific autoconf-like config file > + * which unix creates at ./configure time. > */ > =20 > -#ifdef NETWARE > - > #ifndef APR_PRIVATE_H > #define APR_PRIVATE_H > =20 > -/* Include the public APR symbols, include our idea of the 'right' > - * subset of the Windows.h header. This saves us repetition. > - */ > -#include "apr.h" > - > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > /* Use this section to define all of the HAVE_FOO_H > * that are required to build properly. > */ > @@ -71,19 +56,10 @@ > #define HAVE_WRITEV 1 > =20 > #define HAVE_GETPASS_R 1 > -/* > - * check for older NDKs which have only the getpassword() function. > - */ > -#include > -#if (CURRENT_NDK_THRESHOLD < 709060000) > -#define getpass_r getpassword > -#endif can you please explain to me why you think that NetWare doesnt need this check / define any longer, and why you removed it? thanks, G=C3=BCn.