From dev-return-22676-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue Dec 15 10:57:56 2009 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 44728 invoked from network); 15 Dec 2009 10:57:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Dec 2009 10:57:55 -0000 Received: (qmail 80303 invoked by uid 500); 15 Dec 2009 10:57:55 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 80189 invoked by uid 500); 15 Dec 2009 10:57:54 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 80181 invoked by uid 99); 15 Dec 2009 10:57:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2009 10:57:54 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of minfrin@sharp.fm designates 72.32.122.20 as permitted sender) Received: from [72.32.122.20] (HELO chandler.sharp.fm) (72.32.122.20) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2009 10:57:45 +0000 Received: from chandler.sharp.fm (localhost [127.0.0.1]) by chandler.sharp.fm (Postfix) with ESMTP id C2711780D8; Tue, 15 Dec 2009 04:57:24 -0600 (CST) Received: from 87-194-125-14.bethere.co.uk (87-194-125-14.bethere.co.uk [87.194.125.14]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: minfrin@sharp.fm) by chandler.sharp.fm (Postfix) with ESMTP id 47EEE78097; Tue, 15 Dec 2009 04:57:24 -0600 (CST) Message-ID: <4B276B93.1090000@sharp.fm> Date: Tue, 15 Dec 2009 12:57:23 +0200 From: Graham Leggett User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: "William A. Rowe Jr." CC: dev@apr.apache.org Subject: Re: svn commit: r890580 - in /apr/apr-util/branches/1.4.x: crypto/apr_crypto.c crypto/apr_crypto_nss.c crypto/apr_crypto_openssl.c include/apr_crypto.h include/private/apr_crypto_internal.h test/testcrypto.c References: <20091215002943.87FA023888FE@eris.apache.org> <4B26E10D.7020304@rowe-clan.net> <4B26E424.1050706@rowe-clan.net> <4B27649D.6090900@sharp.fm> <4B27697D.1040509@rowe-clan.net> In-Reply-To: <4B27697D.1040509@rowe-clan.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Virus-Checked: Checked by ClamAV on apache.org William A. Rowe Jr. wrote: > As I mentioned, the actual contents of the structure are flexible IMHO. > As a user, folks aren't expected to know the difference, but as a developer, > something clearly labeled -alpha should be expected to be changing still. > > So if a *developer* coded to any of these API's, well, all bets are off. > > But we can leave the apr_crypto_driver_t at the same position as it was > originally in the structure, no? I plan to revert the entire change to v1.4 as you've requested, as making apr_crypto_t private is definitely an incompatible ABI change given that v1.4.x has been released. I can then just focus on v2, where this problem can be fixed properly for dbd and crypto (and then ldap). Regards, Graham --