apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: Prepared to tag apr-util 1.4.1
Date Fri, 11 Dec 2009 16:02:34 GMT
On Thu, Dec 10, 2009 at 12:02 AM, William A. Rowe Jr.
<wrowe@rowe-clan.net> wrote:
>
> --- apr_hooks.h (.../1.3.x/include)     (revision 889020)
> +++ apr_hooks.h (.../1.4.x/include)     (revision 889020)
> @@ -21,6 +21,23 @@
>  /* For apr_array_header_t */
>  #include "apr_tables.h"
>
> +#ifdef APR_DTRACE_PROVIDER
> +#include <sys/sdt.h>
> +#ifndef OLD_DTRACE_PROBE
> +#define OLD_DTRACE_PROBE(name) __dtrace_ap___##name()
> +#endif
> [...]
>
> Are the OLD_DTRACE macros truly dtrace's, or are these actually ours and
> perhaps worthy of namespace protection?

They're ours AFAICT.  Also, the embedded _ap_ in the generated probe
name reflects that these were only used within httpd; that should use
the hook namespace.

I'll look through this in the next couple of days.  (GROAN)

Mime
View raw message