apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sander Temme <san...@temme.net>
Subject Re: [VOTE] release apr-1.4.1 [no -util release]
Date Sun, 13 Dec 2009 02:39:03 GMT

On Dec 12, 2009, at 4:07 PM, William A. Rowe Jr. wrote:

> Sander Temme wrote:
>> Unless my caffeine-starved brain is reading this wrong, should we put in a special
case in the 'l' modifier (line 832) that catches 'll' and sets the variable type to IS_QUAD?

> 
> In any case, if sizeof(long long) == sizeof(long) == sizeof(int)

Actually, int is 4 bytes, long and long long are 8 on this platform. 

> we should always be respecting %lld, %ld and %d as equivalent.

So, sadly, there is a difference.  

But do you agree that we should support %lld and that inside the if statement starting line
832 of apr_snprintf.c is a good spot to set var_type = IS_QUAD?

S.

-- 
sander@temme.net              http://www.temme.net/sander/
PGP FP: 51B4 8727 466A 0BC3 69F4  B7B8 B2BE BC40 1529 24AF


Mime
View raw message