Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of trawick@gmail.com designates
 209.85.222.185 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=feLVBoH+yzlzwyl3qf9qQLShvIYOTUMgKh30t7svnmWOCCmaLvFnHY8wFmthIb/zYM
         Hjt5mf3bIb2Ie0gZuRn6n7PgCvWBcnmEGLOp+014+A42/QG5jbRmFd2hvbYkLEX6oq1C
         n+btDfGjIHesuIDxDADoQ7ecSHF2+DmSePjRY=
MIME-Version: 1.0
In-Reply-To: <4B018586.6090807@rowe-clan.net>
References: <20091112232020.DEAE323888BD@eris.apache.org>
	 <cc67648e0911160845i46b77df5kdd62b18d91d1b6ee@mail.gmail.com>
	 <4B018586.6090807@rowe-clan.net>
Date: Mon, 16 Nov 2009 13:56:42 -0500
Message-ID: <cc67648e0911161056o1f039c20u5d31b4b231ed92b2@mail.gmail.com>
Subject: Re: svn commit: r835634 - in /apr/apr-util/branches/1.4.x: buildconf
	xml/expat/buildconf.sh xml/expat/configure.in
From: Jeff Trawick <trawick@gmail.com>
To: dev@apr.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 16, 2009 at 12:01 PM, William A. Rowe Jr.
<wrowe@rowe-clan.net> wrote:
> Jeff Trawick wrote:
>>>
>>> Modified: apr/apr-util/branches/1.4.x/xml/expat/buildconf.sh
>>> URL: http://svn.apache.org/viewvc/apr/apr-util/branches/1.4.x/xml/expat=
/buildconf.sh?rev=3D835634&r1=3D835633&r2=3D835634&view=3Ddiff
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>> --- apr/apr-util/branches/1.4.x/xml/expat/buildconf.sh (original)
>>> +++ apr/apr-util/branches/1.4.x/xml/expat/buildconf.sh Thu Nov 12 23:20=
:20 2009
>>
>>> @@ -42,12 +47,12 @@
>>> =A0cat $ltfile >> aclocal.m4
>>>
>>> =A0if [ -f ltsugar.m4 ]; then
>>> - =A0echo "Incorporating ltsugar.m4 into aclocal.m4 ..."
>>> - =A0cat ltsugar.m4 >> aclocal.m4
>>> + =A0 rm -f conftools/ltsugar.m4
>>> + =A0 mv ltsugar.m4 conftools/ltsugar.m4
>>> =A0fi
>>>
>>> -# Clean up again
>>> -rm -f libtool.m4 ltsugar.m4
>>> +# Clean up any leftovers
>>> +rm -f aclocal.m4 libtool.m4
>>
>> removing aclocal.m4 is a killer for me with
>>
>> - Solaris 10
>> - in-tree expat
>> - autoconf 2.61
>> - libtool 1.5.26
>> - automake 1.11
>
> That's cut and paste from apr, hrmmm. =A0Happy to take a second look at t=
his.
>
>> AC_PROG_LIBTOOL and AC_LIBTOOL_WIN32_DLL aren't found.
>>
>> Find the discussions around r388605 too ;)
>
> So not 'in general', only after libtoolizing them rm'ing aclocal.m4?

I'm not sure what you mean here... we create aclocal.m4 based on
libtool.m4 then whack it almost immediately; aclocal.m4 is where
autoconf would find AC_PROG_LIBTOOL et al.


> I will go
> back and take a second look at what we did in apr-1.x vs xml/expat/
>

apr is a little different...  it uses libtool.m4 to create
build/libtool.m4, and APR's configure.in does
sinclude(build/libtool.m4).

hmmm... you changed xml/expat/configure.in to
sinclude(conftools/libtool.m4); I guess conftools is where you
expected it to be?

libtoolize (1.5.26) doesn't create libtool.m4 anywhere in the
xml/expat tree; it ends up being copied from libtool's
share/aclocal/libtool.m4 to aclocal.m4