Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 91701 invoked from network); 16 Nov 2009 17:02:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 16 Nov 2009 17:02:25 -0000 Received: (qmail 63662 invoked by uid 500); 16 Nov 2009 17:02:24 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 63573 invoked by uid 500); 16 Nov 2009 17:02:24 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 63565 invoked by uid 99); 16 Nov 2009 17:02:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Nov 2009 17:02:24 +0000 X-ASF-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,URIBL_BLACK X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [72.167.82.81] (HELO p3plsmtpa01-01.prod.phx3.secureserver.net) (72.167.82.81) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 16 Nov 2009 17:02:22 +0000 Received: (qmail 24291 invoked from network); 16 Nov 2009 17:02:00 -0000 Received: from unknown (76.252.112.72) by p3plsmtpa01-01.prod.phx3.secureserver.net (72.167.82.81) with ESMTP; 16 Nov 2009 17:02:00 -0000 Message-ID: <4B018586.6090807@rowe-clan.net> Date: Mon, 16 Nov 2009 11:01:58 -0600 From: "William A. Rowe Jr." User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Jeff Trawick CC: dev@apr.apache.org Subject: Re: svn commit: r835634 - in /apr/apr-util/branches/1.4.x: buildconf xml/expat/buildconf.sh xml/expat/configure.in References: <20091112232020.DEAE323888BD@eris.apache.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Jeff Trawick wrote: >> >> Modified: apr/apr-util/branches/1.4.x/xml/expat/buildconf.sh >> URL: http://svn.apache.org/viewvc/apr/apr-util/branches/1.4.x/xml/expat/buildconf.sh?rev=835634&r1=835633&r2=835634&view=diff >> ============================================================================== >> --- apr/apr-util/branches/1.4.x/xml/expat/buildconf.sh (original) >> +++ apr/apr-util/branches/1.4.x/xml/expat/buildconf.sh Thu Nov 12 23:20:20 2009 > >> @@ -42,12 +47,12 @@ >> cat $ltfile >> aclocal.m4 >> >> if [ -f ltsugar.m4 ]; then >> - echo "Incorporating ltsugar.m4 into aclocal.m4 ..." >> - cat ltsugar.m4 >> aclocal.m4 >> + rm -f conftools/ltsugar.m4 >> + mv ltsugar.m4 conftools/ltsugar.m4 >> fi >> >> -# Clean up again >> -rm -f libtool.m4 ltsugar.m4 >> +# Clean up any leftovers >> +rm -f aclocal.m4 libtool.m4 > > removing aclocal.m4 is a killer for me with > > - Solaris 10 > - in-tree expat > - autoconf 2.61 > - libtool 1.5.26 > - automake 1.11 That's cut and paste from apr, hrmmm. Happy to take a second look at this. > AC_PROG_LIBTOOL and AC_LIBTOOL_WIN32_DLL aren't found. > > Find the discussions around r388605 too ;) So not 'in general', only after libtoolizing them rm'ing aclocal.m4? I will go back and take a second look at what we did in apr-1.x vs xml/expat/