Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 92456 invoked from network); 10 Oct 2009 06:56:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 Oct 2009 06:56:45 -0000 Received: (qmail 16315 invoked by uid 500); 10 Oct 2009 06:56:44 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 16221 invoked by uid 500); 10 Oct 2009 06:56:44 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 16213 invoked by uid 99); 10 Oct 2009 06:56:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Oct 2009 06:56:44 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [209.85.222.185] (HELO mail-pz0-f185.google.com) (209.85.222.185) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Oct 2009 06:56:35 +0000 Received: by pzk15 with SMTP id 15so256578pzk.3 for ; Fri, 09 Oct 2009 23:56:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.164.9 with SMTP id m9mr283821rve.239.1255157774113; Fri, 09 Oct 2009 23:56:14 -0700 (PDT) In-Reply-To: <1255145394.4698.44.camel@shrek.rexursive.com> References: <1255145394.4698.44.camel@shrek.rexursive.com> From: Kevac Marko Date: Sat, 10 Oct 2009 10:55:54 +0400 Message-ID: Subject: Re: [PATCH] fix for max_length field to be populated for prepared statements To: Bojan Smojver Cc: dev@apr.apache.org Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org Well, yes. It is not used in apr_dbd_mysql. For our project we are using apr_dbd, which don't have enough features yet for our needs. For example, we are using information from MYSQL_FIELD structure, which, again, is not available from apr_dbd.h functions. Anyway, with some dark "hack" magic one can access it (of course in non-portable manner). Variable max_length in MYSQL_FIELD is not populated for prepared statements without flag in patch. This is why we need it. Maybe this violates some kind of "not needed feature" rule. If so, than what is your advice? Thanks. On Sat, Oct 10, 2009 at 7:29 AM, Bojan Smojver wrote: > On Thu, 2009-10-01 at 14:20 +0400, Kevac Marko wrote: >> Without this attribute set, max_length field is not filled for >> prepared statements. > > I'm not seeing use of max_length in the driver. Can you elaborate a bit > more what this is for? > > >From what I can see we rely on buffer_length for prepared stuff, no? > > -- > Bojan > > -- Marko Kevac Sent from Moscow, Mow, Russia