Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 59688 invoked from network); 8 Oct 2009 20:09:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Oct 2009 20:09:00 -0000 Received: (qmail 7177 invoked by uid 500); 8 Oct 2009 20:09:00 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 7082 invoked by uid 500); 8 Oct 2009 20:09:00 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 7074 invoked by uid 99); 8 Oct 2009 20:09:00 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Oct 2009 20:09:00 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 08 Oct 2009 20:08:57 +0000 Received: (qmail 59622 invoked by uid 2161); 8 Oct 2009 20:08:35 -0000 Received: from [192.168.2.4] (euler.heimnetz.de [192.168.2.4]) by cerberus.heimnetz.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id 3FC381721C for ; Thu, 8 Oct 2009 22:08:26 +0200 (CEST) Message-ID: <4ACE46CF.8050802@apache.org> Date: Thu, 08 Oct 2009 22:08:47 +0200 From: Ruediger Pluem User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.23) Gecko/20090823 SeaMonkey/1.1.18 MIME-Version: 1.0 To: APR Developer List Subject: Re: svn commit: r821524 - in /apr/apr/trunk: CHANGES include/apr_network_io.h libapr.dsp network_io/beos/socketcommon.c network_io/os2/socket_util.c network_io/unix/socket_util.c test/sockchild.c test/testsock.c References: <20091004120958.60C9B238890A@eris.apache.org> <20091006085245.GA5218@redhat.com> <4ACB91A7.3060700@apache.org> <4ACE3914.1070200@apache.org> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 10/08/2009 09:39 PM, Jim Jagielski wrote: > > On Oct 8, 2009, at 3:10 PM, Ruediger Pluem wrote: > >> >> >> On 10/06/2009 08:51 PM, Ruediger Pluem wrote: >>> >>> On 10/06/2009 10:52 AM, Joe Orton wrote: >> >>> >>>> or something similar? The API docs should reflect that the return >>>> value >>>> is 1-on-success/zero-on-failure (unusual for APR), and that the >>>> function >>>> does not block. >>> >>> I can invert the return value as well, but in this case shouldn't this >>> be reflected in the name as well? >>> So with inverted return value shouldn't it be >>> >>> apr_socket_at_read_not_eof >>> >>> or do you think I shouldn't return an int at all and return >>> apr_status_t instead >>> with APR_SUCCESS if the read side of our end of the socket is eof >>> (and leaving the name as apr_socket_at_read_eof in this case)? >> >> Sorry for being impatient here, but Joe any comment on the above? >> I would like to fix this. >> >> Regards >> >> R�diger >> > > apr_socket_readable() ? It is less about the name as such. It is more about whether to return an int or apr_status_t and what the return value should be in the case that the peer has closed the socket. Regards R�diger