apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevac Marko <ma...@kevac.org>
Subject Re: [PATCH] add some flags to apr_dbd_mysql flags parameter
Date Fri, 09 Oct 2009 09:21:20 GMT
I would like to head word or two from apr-lib mantainers about this
patch. Thanks.

On Fri, Oct 2, 2009 at 10:47 AM, Kevac Marko <marko@kevac.org> wrote:
> I have filled the bug - https://issues.apache.org/bugzilla/show_bug.cgi?id=47931
>
> On Thu, Oct 1, 2009 at 2:10 PM, Kevac Marko <marko@kevac.org> wrote:
>> Hello.
>>
>> What do you think about this patch?
>> Without one of these flags CALL does not work. But with them, CALL
>> works as it should.
>>
>> diff --git a/dbd/apr_dbd_mysql.c b/dbd/apr_dbd_mysql.c
>> index 77fa5fb..01afed2 100644
>> --- a/dbd/apr_dbd_mysql.c
>> +++ b/dbd/apr_dbd_mysql.c
>> @@ -1156,9 +1156,16 @@ static apr_dbd_t *dbd_mysql_open(apr_pool_t
>> *pool, const char *params,
>>     if (fields[4].value != NULL) {
>>         port = atoi(fields[4].value);
>>     }
>> -    if (fields[6].value != NULL &&
>> -        !strcmp(fields[6].value, "CLIENT_FOUND_ROWS")) {
>> -        flags |= CLIENT_FOUND_ROWS; /* only option we know */
>> +    if (fields[6].value != NULL) {
>> +        if (strstr(fields[6].value, "CLIENT_FOUND_ROWS")) {
>> +            flags |= CLIENT_FOUND_ROWS;
>> +        }
>> +        else if (strstr(fields[6].value, "CLIENT_MULTI_STATEMENTS")) {
>> +            flags |= CLIENT_MULTI_STATEMENTS;
>> +        }
>> +        else if (strstr(fields[6].value, "CLIENT_MULTI_RESULTS")) {
>> +            flags |= CLIENT_MULTI_RESULTS;
>> +        }
>>     }
>>     if (fields[7].value != NULL) {
>>         sql->fldsz = atol(fields[7].value);
>>
>> --
>> Marko Kevac
>> Sent from Moscow, Mow, Russia
>>
>
>
>
> --
> Marko Kevac
> Sent from Moscow, Mow, Russia
>



-- 
Marko Kevac
Sent from Moscow, Mow, Russia

Mime
View raw message