Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 29336 invoked from network); 29 Sep 2009 11:35:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 29 Sep 2009 11:35:34 -0000 Received: (qmail 83572 invoked by uid 500); 29 Sep 2009 11:35:32 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 83349 invoked by uid 500); 29 Sep 2009 11:35:32 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 83330 invoked by uid 99); 29 Sep 2009 11:35:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2009 11:35:32 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [195.232.224.74] (HELO mailout05.vodafone.com) (195.232.224.74) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2009 11:35:20 +0000 Received: from mailint05 (localhost [127.0.0.1]) by mailout05 (Postfix) with ESMTP id B5CDF14649E for ; Tue, 29 Sep 2009 13:34:59 +0200 (CEST) Received: from avoexs02.internal.vodafone.com (unknown [145.230.4.135]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mailint05 (Postfix) with ESMTPS id A9F0914627D; Tue, 29 Sep 2009 13:34:59 +0200 (CEST) Received: from VF-MBX11.internal.vodafone.com ([145.230.5.20]) by avoexs02.internal.vodafone.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 29 Sep 2009 13:35:02 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH-REVIEW] shm.c Date: Tue, 29 Sep 2009 13:35:04 +0200 Message-ID: <99EA83DCDE961346AFA9B5EC33FEC08B02C79C3B@VF-MBX11.internal.vodafone.com> In-Reply-To: <4AC1EB0D.5090207@apache.org> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH-REVIEW] shm.c Thread-Index: AcpA9Zr69bvrk/MnTYqr849zvV2mFwAAcp/g References: <4ABAAE16.5040907@sharp.fm> <20090926225451.GA19397@marseille.ucc.usyd.edu.au> <4ABEAAF7.40403@apache.org> <20090927013613.GE19397@marseille.ucc.usyd.edu.au> <4ABF8179.7090305@apache.org> <4AC16CAC.2080207@apache.org> <4AC1EB0D.5090207@apache.org> From: =?iso-8859-1?Q?=22Pl=FCm=2C_R=FCdiger=2C_VF-Group=22?= To: , "APR Developer List" X-OriginalArrivalTime: 29 Sep 2009 11:35:02.0108 (UTC) FILETIME=[E1FE31C0:01CA40F8] X-Virus-Checked: Checked by ClamAV on apache.org =20 > -----Original Message----- > From: Guenter Knauf=20 > Sent: Dienstag, 29. September 2009 13:10 > To: dev@httpd.apache.org; APR Developer List > Subject: Re: [PATCH-REVIEW] shm.c >=20 > Hi, > Guenter Knauf schrieb: > > can you perhaps review and verify if this patch fixes the Sun Studio > > warnings in shm.c? > > http://people.apache.org/~fuankg/diffs/shm.c.diff > > whole file apr/shmem/unix/shm.c: > > http://people.apache.org/~fuankg/diffs/shm.c > > Maybe I did something wrong, but at least it compiled for=20 > me on Linux, > > and all tests passed ... > Jie reported already that Sun Studio is calm with it ... > perhaps a critival review from someone (Ruediger?) before I commit? Looks fine to me. Passes the tests. Regards R=FCdiger