apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plüm, Rüdiger, VF-Group" <ruediger.pl...@vodafone.com>
Subject RE: [PATCH-REVIEW] shm.c
Date Tue, 29 Sep 2009 11:35:04 GMT
 

> -----Original Message-----
> From: Guenter Knauf 
> Sent: Dienstag, 29. September 2009 13:10
> To: dev@httpd.apache.org; APR Developer List
> Subject: Re: [PATCH-REVIEW] shm.c
> 
> Hi,
> Guenter Knauf schrieb:
> > can you perhaps review and verify if this patch fixes the Sun Studio
> > warnings in shm.c?
> > http://people.apache.org/~fuankg/diffs/shm.c.diff
> > whole file apr/shmem/unix/shm.c:
> > http://people.apache.org/~fuankg/diffs/shm.c
> > Maybe I did something wrong, but at least it compiled for 
> me on Linux,
> > and all tests passed ...
> Jie reported already that Sun Studio is calm with it ...
> perhaps a critival review from someone (Ruediger?) before I commit?

Looks fine to me. Passes the tests.

Regards

Rüdiger


Mime
View raw message