From dev-return-22111-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Mon Aug 03 14:37:16 2009 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 92113 invoked from network); 3 Aug 2009 14:37:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Aug 2009 14:37:15 -0000 Received: (qmail 19271 invoked by uid 500); 3 Aug 2009 14:37:20 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 19158 invoked by uid 500); 3 Aug 2009 14:37:20 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 19149 invoked by uid 99); 3 Aug 2009 14:37:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2009 14:37:20 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.202.165.95] (HELO smtpauth04.prod.mesa1.secureserver.net) (64.202.165.95) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 03 Aug 2009 14:37:09 +0000 Received: (qmail 5081 invoked from network); 3 Aug 2009 14:36:45 -0000 Received: from unknown (76.252.112.72) by smtpauth04.prod.mesa1.secureserver.net (64.202.165.95) with ESMTP; 03 Aug 2009 14:36:45 -0000 Message-ID: <4A76F5ED.9050807@rowe-clan.net> Date: Mon, 03 Aug 2009 09:36:29 -0500 From: "William A. Rowe, Jr." User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: Ruediger Pluem CC: APR Developer List Subject: Re: svn commit: r799780 - /apr/apr-util/branches/1.3.x/dbd/apr_dbd_mysql.c References: <20090801004040.E74152388867@eris.apache.org> <4A73F1D9.7020203@apache.org> <1249284448.22379.2.camel@shrek.rexursive.com> <4A76A69B.3030802@gmx.de> <1249290435.22379.3.camel@shrek.rexursive.com> <4A76AB19.60403@apache.org> In-Reply-To: <4A76AB19.60403@apache.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org Ruediger Pluem wrote: > > On 08/03/2009 11:07 AM, Bojan Smojver wrote: >> On Mon, 2009-08-03 at 10:58 +0200, Rüdiger Plüm wrote: >>> Bill, does this work on Windows as well? >> Doesn't this patch bring us back where we were (roughly)? >> > > Not really. Bills patch ensured that we consistently pickup > the headers from the mysql subdir or from one level above. > But you are correct my patch reverses the ordering Bill introduced. > Hence my question to him :-). Yes, it does essentially revert, but throws away several legibility issues and bad practices (#define HAVE_THAT_H in a .c source? seriously ;-?) I can't follow the old code, but it is entirely possible to have picked up global/sys from one system install and mysql.h from another, which can't possibly be a good thing. Mine and Rued I've applied this, since apparently it's not possible to both compile against my_global/my_sys on unix and windows. On windows, this is broken since my_sys includes far too many #LL constants and such that seem solely destined for gcc (Mingw perhaps). What is interesting, it appears my_sys is not actually used, and the my_global header solves the my_init binding problem. It would make sense to enable only that one header, on Windows; issues solved.