apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH] handling hook predecessors when predecessor has hooked more than once
Date Sun, 17 May 2009 15:50:46 GMT
On Fri, May 15, 2009 at 3:26 PM, Jeff Trawick <trawick@gmail.com> wrote:

> mod_p hooks the post_config more than once, including really_last.  mod_s's
> post_config has to run after mod_p's post_config (both of them) for one of
> its features to work.  I tried adding "mod_p.c" to the predecessor list in
> mod_s, but it wasn't effective, as predecessor processing doesn't account
> for the possibility that the predecessor may have hooked more than once.
>
> No claims here to understand all the hook sorting; I found some code that I
> was expecting, changed it, was happy, changed the LoadModule order, was
> still happy, but noted that there's some other, less obvious code that
> touches predecessors too (tsort()).
>
> Any thoughts before I test in more detail?


It wasn't so simple ;)  I'd love to stare at the code long enough to resolve
it, but I fear I won't get back to it.  For now I'll commit a new testcase
for hooks.

Mime
View raw message