From dev-return-21590-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Mar 26 01:19:37 2009 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 71337 invoked from network); 26 Mar 2009 01:19:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 26 Mar 2009 01:19:33 -0000 Received: (qmail 42366 invoked by uid 500); 25 Mar 2009 20:56:14 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 42318 invoked by uid 500); 25 Mar 2009 20:56:14 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 42309 invoked by uid 99); 25 Mar 2009 20:56:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Mar 2009 20:56:14 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.218.164] (HELO mail-bw0-f164.google.com) (209.85.218.164) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Mar 2009 20:56:05 +0000 Received: by bwz8 with SMTP id 8so228538bwz.43 for ; Wed, 25 Mar 2009 13:55:44 -0700 (PDT) Received: by 10.223.113.9 with SMTP id y9mr9978fap.61.1238014543968; Wed, 25 Mar 2009 13:55:43 -0700 (PDT) Received: from ?172.31.13.157? (cpe-90-157-172-76.dynamic.amis.net [90.157.172.76]) by mx.google.com with ESMTPS id y15sm10617279fkd.12.2009.03.25.13.55.43 (version=SSLv3 cipher=RC4-MD5); Wed, 25 Mar 2009 13:55:43 -0700 (PDT) Message-ID: <49CA9A4D.1010005@apache.org> Date: Wed, 25 Mar 2009 21:55:41 +0100 From: "=?UTF-8?B?QnJhbmtvIMSMaWJlag==?=" User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: Paul Querna CC: Mladen Turk , "dev@apr.apache.org" Subject: Re: [PATCH] pools always use malloc References: <4239a4320903250723h55d7cc1q917a79bc35c91d7a@mail.gmail.com> <49CA4215.2050806@apache.org> <4239a4320903250741t2893d120oa6baa1ff390d0c89@mail.gmail.com> In-Reply-To: <4239a4320903250741t2893d120oa6baa1ff390d0c89@mail.gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Paul Querna wrote: > On Wed, Mar 25, 2009 at 3:39 PM, Mladen Turk wrote: > >> Paul Querna wrote: >> >>> There have been various discussions on list in the past about the >>> problems with pools, and that newer malloc implementations really are >>> better at it han we can ever be. (jemalloc for example >>> ). >>> >>> Patch: >>> >>> >>> - palloc now used malloc underneath. >>> - we keep a list of malloc'ed adrresses, in a new list object, and >>> free them on clear/destroy >>> - unmanaged/core pool APIs removed. >>> >>> I'd like to just put this into APR-2 trunk asap, and then figure out >>> how to unify the pool debug code with these changes. >>> >>> Thoughts? >>> >>> >> Why did you remove the unmanaged pool? >> > > because when we are using malloc/free, they shouldn't be needed? > Yes they certainly would be if you still want to control cleanup and such.