apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: svn propchange: r747990 - svn:log
Date Mon, 02 Mar 2009 21:55:31 GMT
On Monday 02 March 2009, William A. Rowe, Jr. wrote:
> Stefan Fritsch wrote:
> > Who needs to make sure, the application or apr? Currenty httpd
> > 2.2.x does not mark stderr as inheritable. It doesn't sound good
> > if a change in stable apr requires a change in stable httpd. But
> > I guess you could argue that apps relying on the current
> > behaviour are buggy. Or do you want to add special case code into
> > apr for
> > stdin/stdout/stderr?
>
> There is a special case in apr_file_dup for stdin/out/err.

There is some special case logic in file_io/win32/filedup.c but AFAICS 
it does not concern APR_INHERIT/APR_FILE_NOCLEANUP.

file_io/unix/filedup.c has:

    /* apr_file_dup() retains all old_file flags with the exceptions
     * of APR_INHERIT and APR_FILE_NOCLEANUP.
     * The user must call apr_file_inherit_set() on the dupped
     * apr_file_t when desired.
     */

Do you think it would be ok if this changed for 1.3/1.4 for 
stdin/out/err?

Mime
View raw message