From dev-return-21385-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue Feb 10 08:34:54 2009 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 2722 invoked from network); 10 Feb 2009 08:34:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Feb 2009 08:34:54 -0000 Received: (qmail 53762 invoked by uid 500); 10 Feb 2009 08:34:53 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 53726 invoked by uid 500); 10 Feb 2009 08:34:53 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 53717 invoked by uid 99); 10 Feb 2009 08:34:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2009 00:34:52 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of chip@force-elite.com designates 72.232.80.58 as permitted sender) Received: from [72.232.80.58] (HELO constant.northnitch.com) (72.232.80.58) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2009 08:34:45 +0000 Received: from BlueWater.hsd1.ca.comcast.net (c-67-164-17-54.hsd1.ca.comcast.net [67.164.17.54]) by constant.northnitch.com (Postfix) with ESMTP id F10C08BF9; Tue, 10 Feb 2009 02:35:00 -0600 (CST) Message-ID: <49913C0C.7050605@force-elite.com> Date: Tue, 10 Feb 2009 00:34:20 -0800 From: Paul Querna User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) MIME-Version: 1.0 To: Mladen Turk CC: dev@apr.apache.org Subject: Re: [WIN32] Using WSAPool for Vista+ References: <498FF67B.3030900@apache.org> <1ED067E8EA3B4ABC85180EAB36ABC325@bspc0> <4991395D.4050100@apache.org> In-Reply-To: <4991395D.4050100@apache.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Mladen Turk wrote: > Bing Swen wrote: >> >> But there seems no reason not to use WSAPoll to implement >> apr_pollset_t (when _WIN32_WINNT >= 0x0600), at least for such >> performance gain. > > It's not that simple. > Since apr binary needs to work on any NT (trunk on 2K+) version, > we cannot use a simple pollset replacement. > It has to dynamically check for the WSAPoll presence in > ws2_32.dll and then choose the pollset provider. > > Since it seems there is no point of having generic > apr_pollset provider API, current select implementation > we are using from poll/unix/select.c and poll/unix/poll.c > would need to go to new poll/win32/poll.c as implementation > function pointers. Actual API would call either WSAPoll > (if present in ws2_32.dll) or standard select. we should consider making it dysnamic on all platforms, and selectable at runtime, we have this problem on more platforms than win32.