apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: [PATCH] apr_memcache memory leak with persistent connections
Date Tue, 06 Jan 2009 01:20:51 GMT
On Mon, 2009-01-05 at 13:07 +0200, Sami Tolvanen wrote:

> I would appreciate it if someone more familiar with the memcache code
> could review the patch and let me know if there are any gotchas with
> this approach. Unless there's a better way for fixing the memory leak
> without modifying the API, I propose applying this patch to APR-util as
> more than one apr_memcache user seems to have been affected over the
> years.

Looks pretty good to me (without actually testing it). Pools/sub-pools
and resource list are always tricky...

Would you mind opening a bug and attaching the patch, so it doesn't fall
through the cracks?



View raw message