Return-Path: 
 <dev-return-21173-apmail-apr-dev-archive=apr.apache.org@apr.apache.org>
Delivered-To: apmail-apr-dev-archive@www.apache.org
Received: (qmail 74508 invoked from network); 12 Nov 2008 22:48:12 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 12 Nov 2008 22:48:12 -0000
Received: (qmail 44535 invoked by uid 500); 12 Nov 2008 22:48:19 -0000
Delivered-To: apmail-apr-dev-archive@apr.apache.org
Received: (qmail 44473 invoked by uid 500); 12 Nov 2008 22:48:19 -0000
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dev@apr.apache.org>
List-Help: <mailto:dev-help@apr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apr.apache.org>
List-Id: <dev.apr.apache.org>
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 44462 invoked by uid 99); 12 Nov 2008 22:48:19 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2008 14:48:19 -0800
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of bojan@rexursive.com
 designates 150.101.121.179 as permitted sender)
Received: from [150.101.121.179] (HELO beauty.rexursive.com) (150.101.121.179)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2008 22:47:00 +0000
Received: from [10.1.120.24] (shrek.rexursive.com [10.1.120.24])
	by beauty.rexursive.com (Postfix) with ESMTP id 59EF08C39C
	for <dev@apr.apache.org>; Thu, 13 Nov 2008 09:47:42 +1100 (EST)
Subject: Re: Purpose of defined  APU_HAVE_XXX-DBD in apu.h for dso build
From: Bojan Smojver <bojan@rexursive.com>
To: dev@apr.apache.org
In-Reply-To: <491AEBF0.7030408@apache.org>
References: <491AEBF0.7030408@apache.org>
Content-Type: text/plain
Date: Thu, 13 Nov 2008 09:47:41 +1100
Message-Id: <1226530061.2783.93.camel@shrek.rexursive.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) 
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

On Wed, 2008-11-12 at 15:45 +0100, Mladen Turk wrote:

> If the dbd module is compiled with
> APU_DSO_BUILD it is still defined inside apu.h
> which is IMHO wrong.
> 
> For example
> #define APU_HAVE_SQLITE3 1
> is present although the apr_dbd_sqlite3 module
> was build.
> 
> I was under perception that this should be
> defined only if --disable-util-dso is used
> during configure.

If you don't define those things, your drivers will contain nothing. We
have code like this:

#if APU_HAVE_SQLITE3
<sqlite3 driver code>
#endif

What did you have in mind?

-- 
Bojan