Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 60899 invoked from network); 8 Sep 2008 06:35:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Sep 2008 06:35:36 -0000 Received: (qmail 11536 invoked by uid 500); 8 Sep 2008 06:35:33 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 11492 invoked by uid 500); 8 Sep 2008 06:35:33 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 11481 invoked by uid 99); 8 Sep 2008 06:35:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Sep 2008 23:35:33 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [64.202.165.31] (HELO smtpauth18.prod.mesa1.secureserver.net) (64.202.165.31) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 08 Sep 2008 06:34:34 +0000 Received: (qmail 13130 invoked from network); 8 Sep 2008 06:35:03 -0000 Received: from unknown (80.187.209.104) by smtpauth18.prod.mesa1.secureserver.net (64.202.165.31) with ESMTP; 08 Sep 2008 06:35:02 -0000 Message-ID: <48C4C793.2000602@rowe-clan.net> Date: Mon, 08 Sep 2008 08:34:59 +0200 From: "William A. Rowe, Jr." User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: dev@apr.apache.org CC: commits@apr.apache.org Subject: Re: svn commit: r692949 [1/2] - in /apr/apr-util/trunk: ./ build/ crypto/ test/ test/data/ References: <20080907204248.C822F2388892@eris.apache.org> In-Reply-To: <20080907204248.C822F2388892@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org minfrin@apache.org wrote: > Author: minfrin > Date: Sun Sep 7 13:42:47 2008 > New Revision: 692949 > > URL: http://svn.apache.org/viewvc?rev=692949&view=rev > Log: > Add apr_crypto implementations for OpenSSL and Mozilla NSS. Add a unit > test to verify the interoperability of the two modules. Builds default > to disabled unless explicitly enabled. Critics/Advocates, Please, let's review this submission for objectionable characteristics in the API and put it to rest in New Orleans, rather than last minute firedrills when someone decides to champion the release of 1.4/2.0? Graham, I presume you've reviewed and addressed all of the previous objections of the apr_ssl interface before moving this development from sandbox back into trunk? If not, you mighty rethink this commit and back it out, committing it to it's own sandbox context for deeper review. Bill