apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: svn commit: r692949 [2/2] - in /apr/apr-util/trunk: ./ build/ crypto/ test/ test/data/
Date Wed, 10 Sep 2008 20:13:23 GMT
Ruediger Pluem wrote:

>> +    /* encrypt the block */
>> +    rv = apr_crypto_block_encrypt(driver, block, cipherText + len,
> 
> What is the purpose of cipherText + len?
> len is always 0 and cipherText is char ** and not char *.

That is part of some previous code, it shouldn't be there. Will fix.

> Why do we need a fresh pool for every test? Why can't we create it once 
> for all test?

As it is a test case, no - you ideally want where practical for each 
test case not to depend on or be affected by the results of a previous test.

Regards,
Graham
--

Mime
View raw message