Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of trawick@gmail.com designates
 209.85.128.184 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:references;
        b=aP+YHXbF3bqW6PRezLSN+EaTmEMhFiVET42JgSlqSOBE30oSRtndZH6hK0nQ6ZTEPR
         SfL+F+nNJHEkvkNhiGRpGO73qWuk2pZKHiF615SkywY/WeCn40givVL/dsXVr0sJFoXM
         HOzvRwnShWoYLziyzVy8mjTO+bOtDQKof0d0M=
Message-ID: <cc67648e0808120811q3e26ba61q1a90f1c603d96203@mail.gmail.com>
Date: Tue, 12 Aug 2008 11:11:22 -0400
From: "Jeff Trawick" <trawick@gmail.com>
To: dev@apr.apache.org
Subject: Re: 1.3.3 tarballs for review
In-Reply-To: <489DAB9A.1070007@rowe-clan.net>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_47235_17450423.1218553882066"
References: <489DAB9A.1070007@rowe-clan.net>

------=_Part_47235_17450423.1218553882066
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Sat, Aug 9, 2008 at 10:37 AM, William A. Rowe, Jr.
<wrowe@rowe-clan.net>wrote:

> Available in the usual; http://apr.apache.org/dev/dist/, win32
> with exported .mak files to follow as soon as I have a bit of
> free time, busy weekend here so likely on Sunday eve (when I'll
> look also at committing Carlo's efforts on MinGW).
>
>  +/-1
>  [  ]  Release apr-1.3.3
>  [  ]  Release apr-util-1.3.3
>
> apr and apr-util test results for 1.3.2 and 1.3.3 match on OpenSolaris:

apr:
testsock            : |Line 92: Problem getting http service (2): No such
file or directory

apr-util:
testxlate           : |Line 63: expected <0>, but saw <22>
  (perhaps the lack of expected charset aliases in Solaris iconv()?)

I guess these last two messages are not errors::
Failed to load driver file apr_dbd_sqlite2.so
Failed to load driver file apr_dbd_sqlite3.so

A late code review found this disturbance:

Index: memcache/apr_memcache.c
===================================================================
--- memcache/apr_memcache.c     (.../1.3.2)     (revision 685172)
+++ memcache/apr_memcache.c     (.../1.3.3)     (revision 685172)
...
 static apr_status_t
 mc_conn_construct(void **conn_, void *params, apr_pool_t *pool)
 {
@@ -310,7 +331,11 @@
         return rv;
     }

+#if APR_HAS_THREADS
+    conn = malloc(sizeof( apr_memcache_conn_t )); /* non-pool space! */
+#else
     conn = apr_palloc(np, sizeof( apr_memcache_conn_t ));
+#endif

     conn->p = np;

@@ -334,34 +359,31 @@
     rv = conn_connect(conn);
     if (rv != APR_SUCCESS) {
         apr_pool_destroy(np);
+        free(conn);

That free() must be inside a check for APR_HAS_THREADS (potentially
extremely painful to diagnose, but for a minority of platforms/builds).

------=_Part_47235_17450423.1218553882066
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<div dir="ltr">On Sat, Aug 9, 2008 at 10:37 AM, William A. Rowe, Jr. <span dir="ltr">&lt;<a href="mailto:wrowe@rowe-clan.net">wrowe@rowe-clan.net</a>&gt;</span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Available in the usual; <a href="http://apr.apache.org/dev/dist/" target="_blank">http://apr.apache.org/dev/dist/</a>, win32<br>
with exported .mak files to follow as soon as I have a bit of<br>
free time, busy weekend here so likely on Sunday eve (when I&#39;ll<br>
look also at committing Carlo&#39;s efforts on MinGW).<br>
<br>
 &nbsp;+/-1<br>
 &nbsp;[ &nbsp;] &nbsp;Release apr-1.3.3<br>
 &nbsp;[ &nbsp;] &nbsp;Release apr-util-1.3.3<br>
<br>
</blockquote></div>apr and apr-util test results for 1.3.2 and 1.3.3 match on OpenSolaris:<br><br>apr:<br>testsock&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; : |Line 92: Problem getting http service (2): No such file or directory<br><br>apr-util:<br>testxlate&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; : |Line 63: expected &lt;0&gt;, but saw &lt;22&gt;<br>
&nbsp; (perhaps the lack of expected charset aliases in Solaris iconv()?)<br><br>I guess these last two messages are not errors::<br>Failed to load driver file apr_dbd_sqlite2.so<br>Failed to load driver file apr_dbd_sqlite3.so<br>
<br>A late code review found this disturbance:<br><br>Index: memcache/apr_memcache.c<br>===================================================================<br>--- memcache/apr_memcache.c&nbsp;&nbsp;&nbsp;&nbsp; (.../1.3.2)&nbsp;&nbsp;&nbsp;&nbsp; (revision 685172)<br>
+++ memcache/apr_memcache.c&nbsp;&nbsp;&nbsp;&nbsp; (.../1.3.3)&nbsp;&nbsp;&nbsp;&nbsp; (revision 685172)<br>...<br>&nbsp;static apr_status_t<br>&nbsp;mc_conn_construct(void **conn_, void *params, apr_pool_t *pool)<br>&nbsp;{<br>@@ -310,7 +331,11 @@<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return rv;<br>
&nbsp;&nbsp;&nbsp;&nbsp; }<br>&nbsp;<br>+#if APR_HAS_THREADS<br>+&nbsp;&nbsp;&nbsp; conn = malloc(sizeof( apr_memcache_conn_t )); /* non-pool space! */<br>+#else<br>&nbsp;&nbsp;&nbsp;&nbsp; conn = apr_palloc(np, sizeof( apr_memcache_conn_t ));<br>+#endif<br>&nbsp;<br>&nbsp;&nbsp;&nbsp;&nbsp; conn-&gt;p = np;<br>
&nbsp;<br>@@ -334,34 +359,31 @@<br>&nbsp;&nbsp;&nbsp;&nbsp; rv = conn_connect(conn);<br>&nbsp;&nbsp;&nbsp;&nbsp; if (rv != APR_SUCCESS) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; apr_pool_destroy(np);<br>+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; free(conn);<br><br>That free() must be inside a check for APR_HAS_THREADS (potentially extremely painful to diagnose, but for a minority of platforms/builds).<br>
<br><br></div>

------=_Part_47235_17450423.1218553882066--