apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Trawick" <traw...@gmail.com>
Subject Re: 1.3.3 tarballs for review
Date Tue, 12 Aug 2008 15:11:22 GMT
On Sat, Aug 9, 2008 at 10:37 AM, William A. Rowe, Jr.
<wrowe@rowe-clan.net>wrote:

> Available in the usual; http://apr.apache.org/dev/dist/, win32
> with exported .mak files to follow as soon as I have a bit of
> free time, busy weekend here so likely on Sunday eve (when I'll
> look also at committing Carlo's efforts on MinGW).
>
>  +/-1
>  [  ]  Release apr-1.3.3
>  [  ]  Release apr-util-1.3.3
>
> apr and apr-util test results for 1.3.2 and 1.3.3 match on OpenSolaris:

apr:
testsock            : |Line 92: Problem getting http service (2): No such
file or directory

apr-util:
testxlate           : |Line 63: expected <0>, but saw <22>
  (perhaps the lack of expected charset aliases in Solaris iconv()?)

I guess these last two messages are not errors::
Failed to load driver file apr_dbd_sqlite2.so
Failed to load driver file apr_dbd_sqlite3.so

A late code review found this disturbance:

Index: memcache/apr_memcache.c
===================================================================
--- memcache/apr_memcache.c     (.../1.3.2)     (revision 685172)
+++ memcache/apr_memcache.c     (.../1.3.3)     (revision 685172)
...
 static apr_status_t
 mc_conn_construct(void **conn_, void *params, apr_pool_t *pool)
 {
@@ -310,7 +331,11 @@
         return rv;
     }

+#if APR_HAS_THREADS
+    conn = malloc(sizeof( apr_memcache_conn_t )); /* non-pool space! */
+#else
     conn = apr_palloc(np, sizeof( apr_memcache_conn_t ));
+#endif

     conn->p = np;

@@ -334,34 +359,31 @@
     rv = conn_connect(conn);
     if (rv != APR_SUCCESS) {
         apr_pool_destroy(np);
+        free(conn);

That free() must be inside a check for APR_HAS_THREADS (potentially
extremely painful to diagnose, but for a minority of platforms/builds).

Mime
View raw message