apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: 1.3.3 tarballs for review
Date Sun, 10 Aug 2008 00:34:44 GMT
Tested on Solaris 8 Sparc, compiled with gcc 4.1.2.

Summary: only minor comments, so an non-binding

   [+1]  Release apr-1.3.3
   [+1]  Release apr-util-1.3.3

A) configure
============

1) Warnings
-----------

Two (old) warnings for apr-util

    config.status: WARNING:
    Makefile.in seems to ignore the --datarootdir setting
    config.status: WARNING:
    lib/Makefile.in seems to ignore the --datarootdir setting

Another similar warning for apr

    config.status:1279: WARNING:
    'apr-config.in' seems to ignore the --datarootdir setting

has been fixed between 1.3.0 and 1.3.3, most likely due to this new line:

diff apr-1.3.0/apr-config.in apr-1.3.3/apr-config.in
27a28
 > datarootdir="@datadir@"

2) Missing AC_MSG_RESULT
------------------------

There is a new check AC_MSG_CHECKING(if fcntl returns EACCES when 
F_SETLK is already held), which isn't combined with any AC_MSG_RESULT. 
So the message

    checking if fcntl returns EACCES when F_SETLK is already held...

has no result or newline at it's end and the output line directly 
preoceeds with

     checking if all interprocess locks affect threads... no

3) pid_t format in Solaris
--------------------------

Detection problem is fixed.

B) make
=======

Nothing special.


C) make test
============

1) apr
------

Failed Tests            Total   Fail    Failed %
===================================================
testsock                    8      1     12.50%
Line 92: Problem getting http service (2): No such file or directory

That's ignorable, http is not contained in /etc/services for Solaris 8.

testsockets                 7      1     14.29%
Line 131: Could not bind socket (126): Cannot assign requested address

bind(12, 0x00126DB8, 32, 3)     Err#126 EADDRNOTAVAIL
      AF_INET6  name = ::1  port = 7772

This testsockets result is identical to version 1.3.0.


2) apr-util
-----------

Failed Tests            Total   Fail    Failed %
===================================================
testxlate                   1      1    100.00%

Line 63: expected <0>, but saw <22>

This result is identical to version 1.3.0.

Regards,

Rainer

Mime
View raw message