Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 16384 invoked from network); 26 Jun 2008 01:09:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Jun 2008 01:09:07 -0000 Received: (qmail 6246 invoked by uid 500); 26 Jun 2008 01:09:08 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 6182 invoked by uid 500); 26 Jun 2008 01:09:08 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 6171 invoked by uid 99); 26 Jun 2008 01:09:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jun 2008 18:09:07 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [64.202.165.38] (HELO smtpauth21.prod.mesa1.secureserver.net) (64.202.165.38) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 26 Jun 2008 01:08:17 +0000 Received: (qmail 12538 invoked from network); 26 Jun 2008 01:08:28 -0000 Received: from unknown (71.239.140.137) by smtpauth21.prod.mesa1.secureserver.net (64.202.165.38) with ESMTP; 26 Jun 2008 01:08:28 -0000 Message-ID: <4862EC0B.6050401@rowe-clan.net> Date: Wed, 25 Jun 2008 20:08:27 -0500 From: "William A. Rowe, Jr." User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Ruediger Pluem CC: APR Developer List Subject: Re: Strange continous SEVERE error after upgrading to APR 1.3, Critical poller failure, Timer expired References: <20080625124334.47622daf@grimnir> <1214398513.9932.7.camel@niq.sun.com> <48629FF3.2020509@apache.org> In-Reply-To: <48629FF3.2020509@apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Ruediger Pluem wrote: > > On 06/25/2008 02:55 PM, Nick Kew wrote: >> >> OK, I've just tested APR variants with Event MPM. >> >> It is indeed that fix that breaks it. When I revert >> the fix, the problem goes away. >> >> The original patch posted to fix the same bug works fine. >> Can I suggest you apply the following patch to 1.3.x >> (should work on 1.3.0 or 1.3.2 too) and let us know if >> it fixes the problem you're seeing? >> >> Index: poll/unix/port.c >> =================================================================== >> --- poll/unix/port.c (revision 662044) >> +++ poll/unix/port.c (working copy) >> @@ -315,7 +315,15 @@ >> >> if (ret == -1) { >> (*num) = 0; >> - rv = apr_get_netos_error(); >> + if (errno == EINTR) { >> + rv = APR_EINTR; >> + } >> + else if (errno == ETIME) { >> + rv = APR_TIMEUP; >> + } >> + else { >> + rv = APR_EGENERAL; >> + } >> } >> else if (nget == 0) { >> rv = APR_TIMEUP; >> >> > > Looks good and makes sense. > apr_get_netos_error() in case of ETIME = 720062 > APR_TIMEUP = 70007 > > So they are different. > > But I would do > > rv = apr_get_netos_error(); > > instead > > of > > rv = APR_EGENERAL; Good observations. Folks, you want to fix these regressions before we T&R 1.3.3? Bill