Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 26054 invoked from network); 18 Jun 2008 02:51:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Jun 2008 02:51:16 -0000 Received: (qmail 78100 invoked by uid 500); 18 Jun 2008 02:51:17 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 78049 invoked by uid 500); 18 Jun 2008 02:51:17 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 78038 invoked by uid 99); 18 Jun 2008 02:51:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jun 2008 19:51:17 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=FM_FAKE_HELO_VERIZON,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of donovant@bellatlantic.net designates 206.46.252.44 as permitted sender) Received: from [206.46.252.44] (HELO vms044pub.verizon.net) (206.46.252.44) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jun 2008 02:50:27 +0000 Received: from [192.168.11.2] ([70.22.224.90]) by vms044.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0K2N00H0X18B4BH6@vms044.mailsrvcs.net> for dev@apr.apache.org; Tue, 17 Jun 2008 21:50:35 -0500 (CDT) Date: Tue, 17 Jun 2008 22:50:34 -0400 From: Tom Donovan Subject: Re: Warnings for apr_dbd_odbc.c on 64-bit platforms In-reply-to: <48586CBC.7080509@bellatlantic.net> To: APR Developer List Cc: Bojan Smojver Reply-to: Tom.Donovan@acm.org Message-id: <485877FA.9080703@bellatlantic.net> MIME-version: 1.0 Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 8BIT References: <1213747952.6007.10.camel@shrek.rexursive.com> <48586CBC.7080509@bellatlantic.net> User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) X-Virus-Checked: Checked by ClamAV on apache.org Tom Donovan wrote: > Bojan Smojver wrote: >> I'm getting these on Fedora 9, x86_64: >> ----------------------- >> dbd/apr_dbd_odbc.c: In function ‘odbc_open’: >> dbd/apr_dbd_odbc.c:1010: warning: cast to pointer from integer of >> different size >> dbd/apr_dbd_odbc.c: In function ‘odbc_start_transaction’: >> dbd/apr_dbd_odbc.c:1101: warning: cast to pointer from integer of >> different size >> dbd/apr_dbd_odbc.c: In function ‘odbc_get_entry’: >> dbd/apr_dbd_odbc.c:1310: warning: cast from pointer to integer of >> different size >> dbd/apr_dbd_odbc.c: In function ‘odbc_transaction_mode_set’: >> dbd/apr_dbd_odbc.c:1496: warning: cast to pointer from integer of >> different size >> ----------------------- >> >> That's for these lines: >> ----------------------- >> rc = SQLSetConnectAttr(hdbc, attrs[i], (void *) attrvals[i], 0); >> ... >> rc = SQLSetConnectAttr(handle->dbc, SQL_ATTR_TXN_ISOLATION, (void *) >> handle->transaction_mode, 0); >> ... >> if ((signed int) p > 0) >> ... >> rc = SQLSetConnectAttr(trans->dbc, SQL_ATTR_TXN_ISOLATION, >> (void *) mode, 0); >> ----------------------- >> re: if ((signed int) p > 0) I checked in a safer test for null or -1 value pointers. r669062 (trunk), r669063 (1.3.x) -tom-