apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tom Donovan <donov...@bellatlantic.net>
Subject Re: svn commit: r667328 - in /apr/apr-util/trunk: dbd/apr_dbd.c dbd/apr_dbd_freetds.c dbd/apr_dbd_odbc.c include/apu.h.in
Date Fri, 13 Jun 2008 04:32:11 GMT
Bojan Smojver wrote:
> On Fri, 2008-06-13 at 04:10 +0000, bojan@apache.org wrote:
> 
>> @@ -646,7 +649,7 @@
>>  
>>      if (SQL_SUCCEEDED(rc) || rc == SQL_NO_DATA) {
>>  
>> -        if (rc = SQL_SUCCESS_WITH_INFO
>> +        if (rc == SQL_SUCCESS_WITH_INFO
>>              && ( len_indicator == SQL_NO_TOTAL || len_indicator >= bufsize)
) {
>>              /* not the last read = a full buffer. CLOBs have a null terminator */
>>              *len = bufsize - (IS_CLOB(bd->type) ? 1 : 0 );
> 
> Tom, please check if the above is what you meant.
> 
>> @@ -1327,7 +1331,7 @@
>>      if (!(sq = strchr(s, '\''))) 
>>          return (char *) s;
>>      /* count the single-quotes and allocate a new buffer */
>> -    for (qcount = 1; sq = strchr(sq + 1, '\''); )
>> +    for (qcount = 1; (sq = strchr(sq + 1, '\'')); )
>>          qcount++;
>>      newstr = apr_palloc(pool, strlen(s) + qcount + 1);
>>  
> 
> Ditto.
> 
Yes to both.

The second one doesn't change the behavior, just cleaning up -Wall warnings, right?

-tom-


Mime
View raw message