apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: [vote] Release apr[-util] 1.3.1
Date Mon, 16 Jun 2008 21:19:03 GMT
On Mon, 2008-06-16 at 22:20 +0200, Ruediger Pluem wrote:

>     struct servent *tmp = getservbyname_r((const char *) 0, (const char *) 0,

OUCH!

> 2. The repeated call to AC_CACHE_CHECK leads to multiple output lines in the
>     case that one of the previous tests fails.

Yeah, that was my intention in the patch.

>  With the bug above I got three
>     identical lines that said that the style was none. IMHO this is not what
>     we want. We want to see the final result of these tests (glibc2, Solaris, ...).
>     So my patch calls AC_CACHE_CHECK once and puts in all checks as 3rd parameter.
>     I also removed all AC_CACHE_VAL checks that were in the original code. When
>     AC_CACHE_CHECK executes the code in the third argument we already know that
>     there is no cached result and we need to all three checks (modulo the if statements
>     in between) anyway.

OK, cleaner anyway.

-- 
Bojan


Mime
View raw message