Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of lucian.grijincu@gmail.com
 designates 209.85.198.224 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=niOm5oGHXICBvXxMnAHZCWFxPOagSX4gJzOD5utknSGm2rsKpXPmULsgi4OS9ZEx7mF/4+XK2Qd7ttxGpKS0cmalWqJcrcqGnhiMVfR1sxp/F2nCIRQzOSE/8XcKI+QxYgCObYGkpEgKKyGIcikkWi5++rB5BmHqdCaYvgGKKsE=
Message-ID: <acf3f2e60805101206v7584b14dx40b21aa44b1bbdfe@mail.gmail.com>
Date: Sat, 10 May 2008 22:06:18 +0300
From: "Lucian Adrian Grijincu" <lucian.grijincu@gmail.com>
To: dev@apr.apache.org
Subject: Re: svn commit: r655138 - /apr/apr/trunk/poll/unix/select.c
In-Reply-To: <20080510185229.1A06923889C4@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080510185229.1A06923889C4@eris.apache.org>

On Sat, May 10, 2008 at 9:52 PM,  <fielding@apache.org> wrote:
> Author: fielding
> Date: Sat May 10 11:52:28 2008
> New Revision: 655138
>
> URL: http://svn.apache.org/viewvc?rev=655138&view=rev
> Log:
> silence warning about assignment expression
>
> Modified:
>    apr/apr/trunk/poll/unix/select.c
>
> Modified: apr/apr/trunk/poll/unix/select.c
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/poll/unix/select.c?rev=655138&r1=655137&r2=655138&view=diff
> ==============================================================================
> --- apr/apr/trunk/poll/unix/select.c (original)
> +++ apr/apr/trunk/poll/unix/select.c Sat May 10 11:52:28 2008
> @@ -520,7 +520,7 @@
>             j++;
>         }
>     }
> -    if ((*num) = j)
> +    if (((*num) = j) != 0)
wouldn't just another set of parentheses fix it?
if (((*num) = j))

>         rv = APR_SUCCESS;
>
>     if (descriptors)
>
>
>


-- 
Lucian