Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of dirkx@webweaving.org designates
 209.132.96.45 as permitted sender)
Cc: APR Developer List <dev@apr.apache.org>
Message-Id: <9E2FDF79-B212-4A11-B58C-BB4F26533B6A@webweaving.org>
From: Dirk-Willem van Gulik <dirkx@webweaving.org>
To: Jim Jagielski <jim@jagunet.com>
In-Reply-To: <4B83778A-75C2-44B7-8670-D4C6085854BD@jagunet.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v919.2)
Subject: Re: sendfile in darwin
Date: Wed, 7 May 2008 21:06:57 +0200
References: <BBBE2E0E-BA50-4399-88A6-95EAE733499B@jaguNET.com>
 <48209AFD.9030604@rowe-clan.net>
 <E990CD25-EFD2-4EA8-A075-5E169BF7FE4B@jaguNET.com>
 <A69698EF-B97B-4DB9-9F5E-3C042D0D12EB@jaguNET.com>
 <2EA94233-5650-4168-9071-EE9B4B451C86@jaguNET.com>
 <3B4823DC-C723-47C8-85F6-01C25947728D@jaguNET.com>
 <827F5091-3959-41C0-8286-777AA3643885@jaguNET.com>
 <A93CB818-4810-4287-8C7E-E90925EA07E5@jaguNET.com>
 <7D1DBBCE-871D-44ED-A6EC-8B9105C6C3E2@jaguNET.com>
 <9E084011-40B5-4906-9507-36BDDE2C0852@webweaving.org>
 <4B83778A-75C2-44B7-8670-D4C6085854BD@jagunet.com>


On May 7, 2008, at 8:42 PM, Jim Jagielski wrote:
>
> On May 7, 2008, at 2:31 PM, Dirk-Willem van Gulik wrote:
>
>> Hmm - Jim - that does not quite solve the issue I was discussing on  
>> IRC;
>
> On IRC? What happened to onlist discussions?? :)

Sorry - I was debugging something totally different (I thought) - and  
was
checking that I was not beeing stupid. (see below for the discussion).

Turned out it was related to yours.

>
>> I think below is needed (which does solve the TimeOut issue).
>>
>> --> diff with your version -- anticipate nbytes set to 0 (which has  
>> whole file semantics on BSD and Darwin).
>>
>> Does that make sense ?
>>
>
> This looks like a patch on something that already patches
> things... so I can't comment on whether this makes sense since
> it includes a patch which I have no clue about.
>
> The addition of 'rv = 0' though on line ~453 is almost
> for sure wrong...

Hmm - it makes the "hangs" go away on BSD/Darwin - and preserves the  
use of the header/footer iovec's - which do matter for performance. I  
saw that you posted a more elaborate patch. Let me try that in the  
meantime.

Dw