Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 67133 invoked from network); 8 May 2008 23:50:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 May 2008 23:50:10 -0000 Received: (qmail 62294 invoked by uid 500); 8 May 2008 23:50:11 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 62249 invoked by uid 500); 8 May 2008 23:50:11 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 62238 invoked by uid 99); 8 May 2008 23:50:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 May 2008 16:50:11 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [208.113.200.5] (HELO spaceymail-a6.g.dreamhost.com) (208.113.200.5) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 May 2008 23:49:18 +0000 Received: from [10.2.8.60] (wsip-70-183-62-251.oc.oc.cox.net [70.183.62.251]) by spaceymail-a6.g.dreamhost.com (Postfix) with ESMTP id EC5B0CA7D4; Thu, 8 May 2008 16:49:38 -0700 (PDT) In-Reply-To: References: <2EA94233-5650-4168-9071-EE9B4B451C86@jaguNET.com> <3B4823DC-C723-47C8-85F6-01C25947728D@jaguNET.com> <827F5091-3959-41C0-8286-777AA3643885@jaguNET.com> <7D1DBBCE-871D-44ED-A6EC-8B9105C6C3E2@jaguNET.com> <9E084011-40B5-4906-9507-36BDDE2C0852@webweaving.org> <4B83778A-75C2-44B7-8670-D4C6085854BD@jagunet.com> <20080507185847.GG32380@cr> <6E447C2E-6D85-402B-B312-C7807CA509C1@webweaving.org> <56097.64.172.17.3.1210197491.squirrel@webmail.mipsisrisc.com> <5B426BB9-F9B0-4CFC-8A9A-E6EA08D6C0FC@jagunet.com> Mime-Version: 1.0 (Apple Message framework v753) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <50E9FB03-65C4-4138-B4E1-27BF599F0B48@gbiv.com> Cc: APR Developer List Content-Transfer-Encoding: 7bit From: "Roy T. Fielding" Subject: Re: sendfile in darwin Date: Thu, 8 May 2008 16:49:34 -0700 To: Jim Jagielski X-Mailer: Apple Mail (2.753) X-Virus-Checked: Checked by ClamAV on apache.org On May 8, 2008, at 1:07 PM, Jim Jagielski wrote: > Can anyone else confirm that r654186 (for apr-trunk) and > r654186 (for apr-1.3) fixes sendfile to work under Darwin? > > In particular, both the perl-test framework for httpd as well > as APR's test suite (and test/sendfile ....) pass for me now. I looked at trunk yesterday and found that the writev's are not properly handling EAGAIN/EINTR -- they assume that if anything is sent then the entire header/trailer is sent. The iovec needs to be checked for more bytes than rv and the start pointer moved forward so that the next loop will try again (before setting sent_headers). But then I tried to fix a small bug in ab.c and got stuck in a tar pit... ....Roy