From dev-return-20293-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Fri May 23 16:48:18 2008 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 9383 invoked from network); 23 May 2008 16:48:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 May 2008 16:48:17 -0000 Received: (qmail 87028 invoked by uid 500); 23 May 2008 16:48:18 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 86983 invoked by uid 500); 23 May 2008 16:48:18 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 86972 invoked by uid 99); 23 May 2008 16:48:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 May 2008 09:48:18 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [64.202.165.22] (HELO smtpauth16.prod.mesa1.secureserver.net) (64.202.165.22) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 23 May 2008 16:47:30 +0000 Received: (qmail 1522 invoked from network); 23 May 2008 16:47:44 -0000 Received: from unknown (71.239.140.137) by smtpauth16.prod.mesa1.secureserver.net (64.202.165.22) with ESMTP; 23 May 2008 16:47:44 -0000 Message-ID: <4836F52F.5030103@rowe-clan.net> Date: Fri, 23 May 2008 11:47:43 -0500 From: "William A. Rowe, Jr." User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Brad Nicholes CC: APR Developer List Subject: Re: Disconnected ldap, abstracted dbd. References: <482CB65C.1000306@rowe-clan.net> <482CBBA8.3060100@sharp.fm> <1404e5910805160533v5be0279r4b937c22d58c3735@mail.gmail.com> <482D9D32.6090704@rowe-clan.net> <4835F92B.5040601@rowe-clan.net> <48369655.6720.00AC.0@novell.com> In-Reply-To: <48369655.6720.00AC.0@novell.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Brad Nicholes wrote: > There seems to be a mismatch in how the #define APU_DSO_BUILD is being used. APU_DSO_BUILD has been defined as a boolean yet much of the code is simply checking for the definition rather than the boolean state. Therefore setting APU_DSO_BUILD to 0 doesn't actually turn off the code compilation paths. Shouldn't all of the statements of #ifdef (or #ifndef) APU_DSO_BUILD be changed to #if APU_DSO_BUILD? Quite right, and a caught a few others. 659591 committed and backported to 1.3. Bill