apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Trawick" <traw...@gmail.com>
Subject Re: apr_gethostbyname incorrectly uses htons to convert port number
Date Fri, 02 May 2008 23:52:32 GMT
On Fri, May 2, 2008 at 2:09 PM, William A. Rowe, Jr.
<wrowe@rowe-clan.net> wrote:
> Chris Taylor seems to have identified a significant bug here, but some
> effort at comparing different OS's man pages is probably worthwhile before
> we accept the patch on it's face;
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=44903

It is easy to confirm that the port field is host byte order, and it
is easy to confirm that htons() doesn't pretend to output such a
number ;)

> Would someone on a non-traditional, inverted machine and network byte order
> machine care to validate his findings and commit?

I checked on a traditional, inverted machine and committed to trunk.
I'll try to get to the branches later.

Mime
View raw message