On May 10, 2008, at 12:06 PM, Lucian Adrian Grijincu wrote:
> On Sat, May 10, 2008 at 9:52 PM, <fielding@apache.org> wrote:
>> Author: fielding
>> Date: Sat May 10 11:52:28 2008
>> New Revision: 655138
>>
>> URL: http://svn.apache.org/viewvc?rev=655138&view=rev
>> Log:
>> silence warning about assignment expression
>>
>> Modified:
>> apr/apr/trunk/poll/unix/select.c
>>
>> Modified: apr/apr/trunk/poll/unix/select.c
>> URL: http://svn.apache.org/viewvc/apr/apr/trunk/poll/unix/select.c?
>> rev=655138&r1=655137&r2=655138&view=diff
>> =====================================================================
>> =========
>> --- apr/apr/trunk/poll/unix/select.c (original)
>> +++ apr/apr/trunk/poll/unix/select.c Sat May 10 11:52:28 2008
>> @@ -520,7 +520,7 @@
>> j++;
>> }
>> }
>> - if ((*num) = j)
>> + if (((*num) = j) != 0)
> wouldn't just another set of parentheses fix it?
> if (((*num) = j))
Of course, but that is less recognizable as an intentional assignment.
....Roy
|