apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r659802 - in /apr/apr-util/trunk: CHANGES misc/apr_reslist.c
Date Sun, 25 May 2008 13:07:02 GMT

On 05/24/2008 10:11 PM, Ruediger Pluem wrote:
> 
> 
> On 05/24/2008 07:38 PM, Tom Donovan wrote:
>> Nick Kew wrote:
>>> On Sat, 24 May 2008 15:04:01 +0200
>>> Ruediger Pluem <rpluem@apache.org> wrote:

>>
>> I don't think just calling apr_reslist_invalidate will work.
>>
>> apr_reslist_invalidate assumes that the reslist is not locked; but it 
>> is locked here in apr_reslist_acquire when the expired resource gets 
>> destroyed.
> 
> I agree here. What worries me more is the question if are not missing a 
> call
> to free_container in apr_reslist_invalidate as well.

Forget my worries. apr_reslist_invalidate is fine as we only call apr_reslist_invalidate
for resources that have been taken from the reslist.

> 
> Regarding the two lines: Do you commit Nick or should I?

Thanks for committing. As this change also helps with httpd bug 37770 we should take
care to backport it to 1.3.0.

Regards

RĂ¼diger




Mime
View raw message