apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: Disconnected ldap, abstracted dbd.
Date Fri, 23 May 2008 16:47:43 GMT
Brad Nicholes wrote:
>    There seems to be a mismatch in how the #define APU_DSO_BUILD is being used.  APU_DSO_BUILD
has been defined as a boolean yet much of the code is simply checking for the definition rather
than the boolean state.  Therefore setting APU_DSO_BUILD to 0 doesn't actually turn off the
code compilation paths.  Shouldn't all of the statements of #ifdef (or #ifndef) APU_DSO_BUILD
be changed to #if APU_DSO_BUILD?

Quite right, and a caught a few others.  659591 committed and backported
to 1.3.

Bill

Mime
View raw message