apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r659293 - in /apr/apr-util/trunk: ./ build/ dbd/ include/ include/private/ ldap/ misc/ test/
Date Fri, 23 May 2008 01:23:57 GMT
>> @@ -430,6 +433,7 @@
>>       test $apu_have_sqlite2 = 1 && dsos="$dsos dbd/apr_dbd_sqlite2.la"
>>       test $apu_have_sqlite3 = 1 && dsos="$dsos dbd/apr_dbd_sqlite3.la"
>>       test $apu_have_freetds = 1 && dsos="$dsos dbd/apr_dbd_freetds.la"
>> +     test $apu_has_ldap = 1 && dsos="$dsos ldap/apr_ldap.la"
>>  
>>       APU_MODULES="$APU_MODULES $dsos"
>>    fi
> 
> Shouldn't all this stuff now go into something like build/dso.m4, with
> option called --disable-load-dso or something?

I agree, but you'll notice from my prior commits I tried to reduce the final
size of this patch to make it easier to review...

> I think people may get confused by mixing DBD and LDAP. Or was this
> intentional?

I'll pull this as part of the dbm separation, as a matter of fact I already
had a build/dso.m4 in the tree here :)

Mime
View raw message