apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: Backporting r657500
Date Mon, 19 May 2008 06:49:36 GMT
William A. Rowe, Jr. wrote:
> Mladen Turk wrote:
>> Any problems I backport the
>> http://svn.apache.org/viewvc?rev=657500&view=rev
>> to 1.2 and 1.3 ?
> I'm only worried about misuse; could you add a doxygen note that removing
> the shm while in-use is absolutely not portable?

Think that docs clearly state that its not portable.

However I'm more worried about the following statement:
"The pool cleanup of apr_shm_create (apr_shm_destroy)
  also removes the named resource"
Now this is not true for win32, because the created
file never gets deleted afterwards, so IMHO this
should be fixed by actually deleting the mapping file
in shm_cleanup (distinguishing create/attach of course)


View raw message