apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r655138 - /apr/apr/trunk/poll/unix/select.c
Date Sun, 11 May 2008 21:05:01 GMT
Lucian Adrian Grijincu wrote:
> On Sat, May 10, 2008 at 9:52 PM,  <fielding@apache.org> wrote:
>>     }
>> -    if ((*num) = j)
>> +    if (((*num) = j) != 0)
> wouldn't just another set of parentheses fix it?
> if (((*num) = j))

Actually, ((*num = j)) is legit, or ((*num = j) != 0) for clarity.  The
(*num) parens are redundant in any C code I've ever seen :-)


Mime
View raw message