apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <...@apache.org>
Subject Re: svn commit: r649830 - in /apr/apr/trunk: CHANGES include/apr_poll.h poll/unix/epoll.c poll/unix/kqueue.c poll/unix/poll.c poll/unix/port.c poll/unix/select.c
Date Sun, 04 May 2008 15:18:29 GMT
Mladen Turk wrote:
> mturk@apache.org wrote:
>>
>> URL: http://svn.apache.org/viewvc?rev=649830&view=rev
>> Log:
>> Introduce (again) apr_pollset_wakeup API
>>
>> Modified:
>>     apr/apr/trunk/CHANGES
>>     apr/apr/trunk/include/apr_poll.h
>>     apr/apr/trunk/poll/unix/epoll.c
>>     apr/apr/trunk/poll/unix/kqueue.c
>>     apr/apr/trunk/poll/unix/poll.c
>>     apr/apr/trunk/poll/unix/port.c
>>     apr/apr/trunk/poll/unix/select.c
>>
> 
> Please note that I didn't test nor tried to compile
> kqueue and port implementations (lack of tst platform).
> They might have some copy/paste typos, so please either
> fix directly or send me a patch and I'll commit.

@@ -304,21 +367,32 @@
[chop]

+            if ((pollset->flags & APR_POLLSET_WAKEABLE) &&
+                fd.desc_type == APR_POLL_FILE &&
+                fd.desc.f == pollset->wakeup_pipe[0]) {

I'm guessing fd is a typo for fp.  Fixing - please
shout if I've missed the point of something.

-- 
Nick Kew

Mime
View raw message