apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: svn commit: r659802 - in /apr/apr-util/trunk: CHANGES misc/apr_reslist.c
Date Sat, 24 May 2008 15:07:23 GMT
On Sat, 24 May 2008 15:04:01 +0200
Ruediger Pluem <rpluem@apache.org> wrote:

> Sorry for pointing out this that late. I just thought about it again
> and I guess we have a leak here. I think the following two lines are
> missing here (before and after destroy_resource):
> 
>          reslist->ntotal--;
> 
> > +            rv = destroy_resource(reslist, res);
> 
>          free_container(reslist, res);

Hmmm, good catch.

Maybe it would be better to call apr_reslist_invalidate
at this point, and keep the relevant cleanup in one place.

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/

Mime
View raw message