apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: dbd pgsql autotools patch
Date Wed, 21 May 2008 00:07:25 GMT
On Tue, 2008-05-20 at 20:04 -0400, Bob Rossi wrote:

> I noticed you changed everything but the AC_CHECK_LIB, do you believe
> that is unnecessary, or are you thinking about it?

Not required. We set LDFLAGS specifically for the test (hence the
APR_ADDTO(LDFLAGS, [$pgsql_LDFLAGS])) and then we restore back the
original after the test. Something like this:

  old_libs="$LIBS"
  old_cppflags="$CPPFLAGS"
  old_ldflags="$LDFLAGS"

[... test ...]

  LIBS="$old_libs"
  CPPFLAGS="$old_cppflags"
  LDFLAGS="$old_ldflags"

So, we should be all good now, as long as the latest build/dbd.m4 works
for you on all platforms.

-- 
Bojan


Mime
View raw message