apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: dbd pgsql autotools patch
Date Tue, 20 May 2008 23:49:37 GMT
On Tue, 2008-05-20 at 19:34 -0400, Bob Rossi wrote:
> --- apr-util-1.3.x-2008-05-19-svn/build/dbd.m4  Tue May 20 17:15:38 2008
> +++ apr-util-1.3.x-2008-05-19-svn.changed/build/dbd.m4  Tue May 20 19:18:23 2008
> @@ -53,7 +53,8 @@
>        AC_PATH_PROG([PGSQL_CONFIG],[pg_config],,[$withval/bin])
>        if test "x$PGSQL_CONFIG" != 'x'; then
>          pgsql_CPPFLAGS="-I`$PGSQL_CONFIG --includedir`"
> -        pgsql_LDFLAGS="-L`$PGSQL_CONFIG --libdir` `$PGSQL_CONFIG --libs`"
> +        pgsql_LDFLAGS="-L`$PGSQL_CONFIG --libdir`"
> +        pgsql_LDFLAGS="$pgsql_LDFLAGS `$PGSQL_CONFIG --libs`"
> 
> There are a couple places the above is done, I only had to change it
> here. If this is done in multiple steps, it avoids a ^A inbetween the
> --libdir and --libs command. I don't know where the ^A comes from, but
> when the lines are separated, it goes away. Any ideas?

Must be some Windows-ism that I'm unaware of. Having two lines is not a
problem though.

>        else
>          pgsql_CPPFLAGS="-I$withval/include"
>          pgsql_LDFLAGS="-L$withval/lib "
> @@ -63,9 +64,9 @@
>        APR_ADDTO(LDFLAGS, [$pgsql_LDFLAGS])
> 
> I'm not quiet sure you want to do the above. Do you really want apr to
> depend on all these libraries?

We revert that back to old_ldflags a bit further down in the code. So,
not an issue.

-- 
Bojan


Mime
View raw message