apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: svn commit: r657516 - in /apr/apr-util/trunk/dbd: apr_dbd_mysql.c apr_dbd_pgsql.c
Date Sun, 18 May 2008 10:13:53 GMT
On Sun, 2008-05-18 at 12:02 +0200, Ruediger Pluem wrote:

> Maybe we should return a driver independent error code in the case that the
> row number is < 1. A MySQL specific error code might be somewhat confusing
> to the user as it might tell him that he used -1 as a row number.
> BTW: As far as I see the old behaviour was not to seek at all if the row number
> was < 0. Was this intended?

I think so.

BTW, I think we'll have to do > 0 as you suggested because we cast into
(my_ulonglong), which if it gets value of -1 may become a really, really
big number thus potentially screwing a lot of things and giving
meaningless error messages back.

Anyhow, I'll do the > 0 now.

-- 
Bojan


Mime
View raw message