Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 29285 invoked from network); 13 Apr 2008 11:50:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Apr 2008 11:50:55 -0000 Received: (qmail 64596 invoked by uid 500); 13 Apr 2008 11:50:55 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 64547 invoked by uid 500); 13 Apr 2008 11:50:55 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 64536 invoked by uid 99); 13 Apr 2008 11:50:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Apr 2008 04:50:54 -0700 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [213.191.128.81] (HELO mxout2.iskon.hr) (213.191.128.81) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 13 Apr 2008 11:50:11 +0000 Received: (qmail 24416 invoked from network); 13 Apr 2008 13:50:22 +0200 X-Remote-IP: 213.191.142.122 Received: from unknown (HELO mx.iskon.hr) (213.191.142.122) by mxout2.iskon.hr with SMTP; 13 Apr 2008 13:50:22 +0200 Received: (qmail 7541 invoked from network); 13 Apr 2008 13:50:22 +0200 X-AVScan: ClamAV X-Remote-IP: 89.164.53.88 Received: from 53-88.dsl.iskon.hr (HELO ?192.168.0.10?) (89.164.53.88) by mx.iskon.hr with SMTP; 13 Apr 2008 13:50:22 +0200 Message-ID: <4801F374.3040705@apache.org> Date: Sun, 13 Apr 2008 13:50:12 +0200 From: Mladen Turk User-Agent: Thunderbird 1.5.0.12 (X11/20071129) MIME-Version: 1.0 To: dev@apr.apache.org CC: commits@apr.apache.org Subject: Re: svn commit: r647540 - in /apr/apr/trunk: CHANGES include/apr_poll.h poll/unix/epoll.c poll/unix/kqueue.c poll/unix/poll.c poll/unix/port.c poll/unix/select.c test/testpoll.c References: <20080413083112.3124D1A9832@eris.apache.org> <4801EA26.4050203@force-elite.com> In-Reply-To: <4801EA26.4050203@force-elite.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Paul Querna wrote: > mturk@apache.org wrote: >> Author: mturk >> Date: Sun Apr 13 01:31:03 2008 >> New Revision: 647540 > .... >> Modified: apr/apr/trunk/poll/unix/epoll.c >> URL: >> http://svn.apache.org/viewvc/apr/apr/trunk/poll/unix/epoll.c?rev=647540&r1=647539&r2=647540&view=diff >> >> ============================================================================== >> >> --- apr/apr/trunk/poll/unix/epoll.c (original) >> +++ apr/apr/trunk/poll/unix/epoll.c Sun Apr 13 01:31:03 2008 >> @@ -68,6 +68,8 @@ >> #if APR_HAS_THREADS >> /* A thread mutex to protect operations on the rings */ >> apr_thread_mutex_t *ring_lock; >> + /* Pipe descriptors used for wakeup */ >> + apr_file_t *wakeup_pipe[2]; #endif > > > Why are all of these changes hidden behind APR_HAS_THREADS? > > I don't think they should be. > The idea behind wakeup is that you unblock some thread that is blocked on the pollset_poll call, so threading is presumed and only then it makes sense. However I'm not sure if this can be used from parent/child calling wakeup in parent, causing unblocking in child. If it can, then it could be compiled even without threading support. Regards -- (TM)