From dev-return-19909-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Apr 17 10:32:31 2008 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 63498 invoked from network); 17 Apr 2008 10:32:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Apr 2008 10:32:31 -0000 Received: (qmail 76239 invoked by uid 500); 17 Apr 2008 10:32:31 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 76172 invoked by uid 500); 17 Apr 2008 10:32:30 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 76161 invoked by uid 99); 17 Apr 2008 10:32:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Apr 2008 03:32:30 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.202.165.36] (HELO smtpauth20.prod.mesa1.secureserver.net) (64.202.165.36) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 17 Apr 2008 10:31:38 +0000 Received: (qmail 8243 invoked from network); 17 Apr 2008 10:31:57 -0000 Received: from unknown (85.189.179.110) by smtpauth20.prod.mesa1.secureserver.net (64.202.165.36) with ESMTP; 17 Apr 2008 10:31:57 -0000 Message-ID: <4807271C.2070104@rowe-clan.net> Date: Thu, 17 Apr 2008 11:31:56 +0100 From: "William A. Rowe, Jr." User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Mladen Turk CC: APR Developer List Subject: Re: svn commit: r649000 - in /apr/apr/trunk: include/arch/win32/apr_arch_misc.h misc/win32/misc.c References: <20080417083018.8104D1A9832@eris.apache.org> <48071A0F.1060008@rowe-clan.net> <4807219C.5020402@apache.org> In-Reply-To: <4807219C.5020402@apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Mladen Turk wrote: > William A. Rowe, Jr. wrote: >> mturk@apache.org wrote: >>> +++ apr/apr/trunk/include/arch/win32/apr_arch_misc.h Thu Apr 17 >>> 01:30:14 2008 >>> @@ -180,7 +180,7 @@ >>> DLL_defined = 6 // must define as last idx_ + 1 >>> } apr_dlltoken_e; >>> >>> -FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, char *fnName, int >>> ordinal); >>> +FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, const char *fnName, >>> int ordinal); >> >> This bit is an API breakage (but not a binary ABI breakage). Hmmm. >> >> I can accept it but thought it should be discussed on list. >> > > I thought that was apr private, isn't it? > It isn't exported as far as I can tell. ACK - should be no problem. By the way, what compiler was giving you errors? I've built as far as VC 2008's compiler and hadn't seen any noise here. Bill