From dev-return-19908-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Apr 17 10:09:10 2008 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 54451 invoked from network); 17 Apr 2008 10:09:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Apr 2008 10:09:09 -0000 Received: (qmail 31567 invoked by uid 500); 17 Apr 2008 10:09:09 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 31511 invoked by uid 500); 17 Apr 2008 10:09:09 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 31500 invoked by uid 99); 17 Apr 2008 10:09:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Apr 2008 03:09:09 -0700 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [213.191.128.81] (HELO mxout2.iskon.hr) (213.191.128.81) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 17 Apr 2008 10:08:24 +0000 Received: (qmail 28090 invoked from network); 17 Apr 2008 12:08:35 +0200 X-Remote-IP: 213.191.142.124 Received: from unknown (HELO mx.iskon.hr) (213.191.142.124) by mxout2.iskon.hr with SMTP; 17 Apr 2008 12:08:35 +0200 Received: (qmail 18217 invoked from network); 17 Apr 2008 12:08:34 +0200 X-AVScan: ClamAV X-Remote-IP: 89.164.2.96 Received: from 2-96.dsl.iskon.hr (HELO ?192.168.0.10?) (89.164.2.96) by mx.iskon.hr with SMTP; 17 Apr 2008 12:08:29 +0200 Message-ID: <4807219C.5020402@apache.org> Date: Thu, 17 Apr 2008 12:08:28 +0200 From: Mladen Turk User-Agent: Thunderbird 1.5.0.12 (X11/20071129) MIME-Version: 1.0 To: APR Developer List Subject: Re: svn commit: r649000 - in /apr/apr/trunk: include/arch/win32/apr_arch_misc.h misc/win32/misc.c References: <20080417083018.8104D1A9832@eris.apache.org> <48071A0F.1060008@rowe-clan.net> In-Reply-To: <48071A0F.1060008@rowe-clan.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org William A. Rowe, Jr. wrote: > mturk@apache.org wrote: >> +++ apr/apr/trunk/include/arch/win32/apr_arch_misc.h Thu Apr 17 >> 01:30:14 2008 >> @@ -180,7 +180,7 @@ >> DLL_defined = 6 // must define as last idx_ + 1 >> } apr_dlltoken_e; >> >> -FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, char *fnName, int >> ordinal); >> +FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, const char *fnName, >> int ordinal); > > This bit is an API breakage (but not a binary ABI breakage). Hmmm. > > I can accept it but thought it should be discussed on list. > I thought that was apr private, isn't it? It isn't exported as far as I can tell. Regards -- (TM)