From dev-return-19838-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Apr 09 17:55:36 2008 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 47244 invoked from network); 9 Apr 2008 17:55:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Apr 2008 17:55:36 -0000 Received: (qmail 23494 invoked by uid 500); 9 Apr 2008 17:55:34 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 23453 invoked by uid 500); 9 Apr 2008 17:55:34 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 23442 invoked by uid 99); 9 Apr 2008 17:55:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Apr 2008 10:55:34 -0700 X-ASF-Spam-Status: No, hits=-4.0 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Apr 2008 17:54:52 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m39Ht2fB020286; Wed, 9 Apr 2008 13:55:02 -0400 Received: from turnip.manyfish.co.uk (IDENT:U2FsdGVkX1+r6iYVqc8iMnAnZ/Q8cC4qtatZ2EREJZQ@vpn-15-5.rdu.redhat.com [10.11.15.5]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m39HsuA5005325; Wed, 9 Apr 2008 13:54:59 -0400 Received: from jorton by turnip.manyfish.co.uk with local (Exim 4.68) (envelope-from ) id 1JjeVb-0006Sr-Eq; Wed, 09 Apr 2008 18:54:55 +0100 Date: Wed, 9 Apr 2008 18:54:55 +0100 From: Joe Orton To: "Philip M. Gollucci" Cc: dev@apr.apache.org Subject: Re: [PATCH]: FreeBSD ports devel/apr Message-ID: <20080409175455.GA24678@redhat.com> Mail-Followup-To: "Philip M. Gollucci" , dev@apr.apache.org References: <47FBB097.7030409@p6m7g8.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <47FBB097.7030409@p6m7g8.com> User-Agent: Mutt/1.5.17 (2007-11-01) Organization: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in UK and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (USA), Brendan Lane (Ireland), Matt Parson (USA), Charlie Peters (USA) X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Apr 08, 2008 at 01:51:19PM -0400, Philip M. Gollucci wrote: > I'm sending this patch upstream, apr is one of the projects I don't have a > commit bit too, so please review commit, and MFC as needed. That code should be using LDFLAGS rather than LIBS, and it should be adding to, rather than overwriting, both the variables. Can you try this instead? Index: build/dbm.m4 =================================================================== --- build/dbm.m4 (revision 646297) +++ build/dbm.m4 (working copy) @@ -671,8 +671,10 @@ elif test "$withval" = "no"; then apu_have_gdbm=0 else - CPPFLAGS="-I$withval/include" - LIBS="-L$withval/lib " + saved_cppflags="$CPPFLAGS" + saved_ldflags="$LDFLAGS" + CPPFLAGS="$CPPFLAGS -I$withval/include" + LDFLAGS="$LDFLAGS -L$withval/lib " AC_MSG_CHECKING(checking for gdbm in $withval) AC_CHECK_HEADER(gdbm.h, AC_CHECK_LIB(gdbm, gdbm_open, [apu_have_gdbm=1])) @@ -680,6 +682,8 @@ APR_ADDTO(APRUTIL_LDFLAGS, [-L$withval/lib]) APR_ADDTO(APRUTIL_INCLUDES, [-I$withval/include]) fi + CPPFLAGS="$saved_cppflags" + LDFLAGS="$saved_ldflags" fi ])