apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@gbiv.com>
Subject Re: svn commit: r651704 - in /apr/apr/trunk: file_io/unix/copy.c include/arch/netware/apr_arch_file_io.h include/arch/os2/apr_arch_file_io.h include/arch/unix/apr_arch_file_io.h include/arch/win32/apr_arch_file_io.h
Date Fri, 25 Apr 2008 22:01:56 GMT
On Apr 25, 2008, at 2:52 PM, bojan@apache.org wrote:

> ====================================================================== 
> ========
> --- apr/apr/trunk/file_io/unix/copy.c (original)
> +++ apr/apr/trunk/file_io/unix/copy.c Fri Apr 25 14:52:36 2008
> @@ -54,7 +54,8 @@
>
>      /* Copy bytes till the cows come home. */
>      while (1) {
> -        char buf[APR_BUFSIZ];
> +        char buf[BUFSIZ > APR_FILE_DEFAULT_BUFSIZE ? BUFSIZ
> +                                                   :  
> APR_FILE_DEFAULT_BUFSIZE];

I'm not sure that is portable C.  Is the compiler guaranteed to  
optimize that
into a constant?

....Roy


Mime
View raw message