apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: Releasing 1.3.0, releasing 1.2.14?
Date Thu, 17 Apr 2008 19:40:29 GMT
William A. Rowe, Jr. wrote:
> So... heading home at last, and I'll be in a position to tag and roll.
> 
> The question is, are we really happy yet that everything troublesome has
> been pulled from trunk/?
> 
> Or do we want to pop off a 1.2.14 'last' release and give ourselves some
> breathing room?
> 
> The httpd project is awaiting this tag and I really don't want to hold
> up taggin past Monday.
> 
> Bill
Will, please apply the below as tweaked by jorton@ first to 1.3.0 and 1.2.14

That code should be using LDFLAGS rather than LIBS, and it should be
adding to, rather than overwriting, both the variables.  Can you try
this instead?

I've tested his patch and its good!


Index: build/dbm.m4
===================================================================
--- build/dbm.m4	(revision 646297)
+++ build/dbm.m4	(working copy)
@@ -671,8 +671,10 @@
      elif test "$withval" = "no"; then
        apu_have_gdbm=0
      else
-      CPPFLAGS="-I$withval/include"
-      LIBS="-L$withval/lib "
+      saved_cppflags="$CPPFLAGS"
+      saved_ldflags="$LDFLAGS"
+      CPPFLAGS="$CPPFLAGS -I$withval/include"
+      LDFLAGS="$LDFLAGS -L$withval/lib "

        AC_MSG_CHECKING(checking for gdbm in $withval)
        AC_CHECK_HEADER(gdbm.h, AC_CHECK_LIB(gdbm, gdbm_open,
[apu_have_gdbm=1]))
@@ -680,6 +682,8 @@
          APR_ADDTO(APRUTIL_LDFLAGS, [-L$withval/lib])
          APR_ADDTO(APRUTIL_INCLUDES, [-I$withval/include])
        fi
+      CPPFLAGS="$saved_cppflags"
+      LDFLAGS="$saved_ldflags"
      fi
    ])




-- 
------------------------------------------------------------------------
Philip M. Gollucci (philip@ridecharge.com)
o:703.549.2050x206
Senior System Admin - Riderway, Inc.
http://riderway.com / http://ridecharge.com
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.


Mime
View raw message